Simpify devLoopEvent message text #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4684 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 340 340
Lines 13370 13370
=======================================
Hits 9784 9784
Misses 2979 2979
Partials 607 607
Continue to review full report at Codecov.
|
|
@briandealwis This is such a huge PR with changes not relevant to DevLoopEvent message. |
|
Changes in pkg/skaffold/event/event.go LGTM! |
|
Oops, I must have been testing a fix elsewhere. |
nkubala
pushed a commit
to nkubala/skaffold
that referenced
this pull request
Aug 20, 2020
nkubala
pushed a commit
to nkubala/skaffold
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4662
Description
Simplify the devLoopEvent messages. Removed the iteration as the user just wants to know about the current iteration.
As per friction log.
User facing changes (remove if N/A)