Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Shell for simpler Quickstart #4830

Merged
merged 2 commits into from Sep 29, 2020

Conversation

briandealwis
Copy link
Member

Fixes: #4813

Description

Adds an Open in Cloud Shell option to the Skaffold Quickstart. Required a minor reorganization to the page to flow better (IMHO).

@briandealwis briandealwis added the docs-modifications runs the docs preview service on the given PR label Sep 28, 2020
@briandealwis briandealwis requested a review from a team as a code owner September 28, 2020 18:49
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 28, 2020
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot
Copy link

Please visit http://35.236.72.108:1313 to view changes to the docs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #4830 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4830      +/-   ##
==========================================
+ Coverage   71.72%   71.73%   +0.01%     
==========================================
  Files         353      353              
  Lines       12099    12108       +9     
==========================================
+ Hits         8678     8686       +8     
- Misses       2775     2776       +1     
  Partials      646      646              
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/manifest/manifests.go 91.48% <0.00%> (-3.11%) ⬇️
cmd/skaffold/app/cmd/filter.go 26.82% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bd638...39ca56f. Read the comment docs.

@briandealwis
Copy link
Member Author

I want to see if there's some better language for non-GCP customers to tell them how to create an account to use the Cloud Shell option.

@MarlonGamez
Copy link
Contributor

I want to see if there's some better language for non-GCP customers to tell them how to create an account to use the Cloud Shell option.

What kind of information do you think we should give to the user about this? Does the user have to do any setup on their account besides creating a google account?

@briandealwis
Copy link
Member Author

PTAL @MarlonGamez — added a note that it requires a Google Account and links to the signup page.

@briandealwis briandealwis added the docs-modifications runs the docs preview service on the given PR label Sep 29, 2020
@container-tools-bot
Copy link

Please visit http://34.94.181.12:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 29, 2020
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@briandealwis briandealwis merged commit 3354747 into GoogleContainerTools:master Sep 29, 2020
@briandealwis briandealwis deleted the i4813 branch September 29, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Quickstart with option to use Cloud Shell
4 participants