Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[design] revise port-forwarding behaviour #4832

Merged
merged 8 commits into from
Mar 17, 2021
Merged

[design] revise port-forwarding behaviour #4832

merged 8 commits into from
Mar 17, 2021

Commits on Sep 29, 2020

  1. Design proposal to revise port-forwarding behaviour

    @briandealwis
    briandealwis committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    3810eb8 View commit details
    Browse the repository at this point in the history

  2. add pointer to corneliusweig's proposal

    @briandealwis
    briandealwis committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    030f14f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Updates from design review meetings 

    - `--port-forwarding` -> `--port-forward-modes`
- created a table summarizing mode changes from v1.15.0
- clarified that `debug` was `skaffold debug`-related ports
- added config settings to `skaffold.yaml` and global config
    @briandealwis
    briandealwis committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    1cac7f1 View commit details
    Browse the repository at this point in the history

  2. Fix the table

    @briandealwis
    briandealwis committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    3ed71dc View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Nick Kubala <nkubala@users.noreply.github.com>
    @briandealwis @nkubala
    briandealwis and nkubala committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    2c45f8a View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. drop defaults and global config -- need a comprehensive strategy

    @briandealwis
    briandealwis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4f74bee View commit details
    Browse the repository at this point in the history

  2. Update status to under implementation

    @briandealwis
    briandealwis committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    497ab40 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Update port-forward.md

    @briandealwis
    briandealwis committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    3dc6da5 View commit details
    Browse the repository at this point in the history