Implement required artifact resolution for cluster builder #4992
Conversation
gsquared94
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4992 +/- ##
==========================================
- Coverage 72.16% 72.14% -0.03%
==========================================
Files 363 363
Lines 12762 12772 +10
==========================================
+ Hits 9210 9214 +4
- Misses 2866 2874 +8
+ Partials 686 684 -2
Continue to review full report at Codecov.
|
| @@ -294,7 +294,7 @@ func TestBuildArgs(t *testing.T) { | |||
| for _, test := range tests { | |||
| testutil.Run(t, "", func(t *testutil.T) { | |||
| tmpDir := t.NewTempDir() | |||
| tmpDir.Write("./Dockerfile", "ARG SKAFFOLD_GO_GCFLAGS\nFROM foo") | |||
| tmpDir.Write("./Dockerfile", "ARG SKAFFOLD_GO_GCFLAGS\nFROM foo\nCMD bar") | |||
There was a problem hiding this comment.
Out of curiosity, why is the CMD bar necessary?
There was a problem hiding this comment.
In #4943 we added additional Dockerfile validation that fails if there isn't atleast one valid command in the Dockerfile.
There was a problem hiding this comment.
That needs to be fixed as ENTRYPOINT and CMD are inherited from the base image.
There was a problem hiding this comment.
You're right. I removed the CMD and tests were fine. I was probably getting error on an empty Dockerfile and I thought this was it.
gsquared94
force-pushed
the
kaniko-builder
branch
from
47a6787
to
ca71321
Compare
Related: #4713, #4922
Description (Part 6 of several PRs.)
This PR implements resolving required artifacts as build args in the kaniko and custom cluster builder as described in the design for supporting dependencies between build artifacts.
A lot of files show as modified since I had to modify the signature of function
docker.EvalBuildArgsto reuse with theKanikoArtifact:The main changes are in
cluster.goto add the calculated build args to theKanikoArtifact.