Fix for humanize time in #5005

[gunadhya]

Fixes: #5005
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

Added go-humanize
I couldn't figure out how to get milliseconds values in the go-humanize library so created a workaround for that.

User facing changes (remove if N/A)

Format for printing output here

Follow-up Work (remove if N/A)

[codecov]

Codecov Report

Merging #5079 (f61028e) into master (35214eb) will increase coverage by 0.01%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master    #5079      +/-   ##
==========================================
+ Coverage   71.82%   71.84%   +0.01%     
==========================================
  Files         387      387              
  Lines       13928    13943      +15     
==========================================
+ Hits        10004    10017      +13     
- Misses       3190     3191       +1     
- Partials      734      735       +1     

Impacted Files	Coverage Δ
pkg/skaffold/diagnose/diagnose.go	15.15% <0.00%> (ø)
pkg/skaffold/util/util.go	83.70% <86.66%> (+0.37%)	⬆️
pkg/skaffold/build/cache/retrieve.go	65.62% <100.00%> (ø)
pkg/skaffold/runner/build_deploy.go	69.89% <100.00%> (ø)
pkg/skaffold/runner/deploy.go	49.29% <100.00%> (ø)
pkg/skaffold/runner/dev.go	69.50% <100.00%> (ø)
pkg/skaffold/runner/load_images.go	94.73% <100.00%> (ø)
pkg/skaffold/runner/timings.go	95.12% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35214eb...f61028e. Read the comment docs.

[tejal29]

Thanks a lot @gunadhya for your PR.

can you please show the change output and how the new line looks?

Also, can you please switch to human readable time elsewhere https://github.com/GoogleContainerTools/skaffold/search?q=time.Since%28start%29

Thanks
Tejal

[tejal29]

Thanks a lot @gunadhya for your PR.

can you please show the change output and how the new line looks?

Also, can you please switch to human readable time elsewhere https://github.com/GoogleContainerTools/skaffold/search?q=time.Since%28start%29

Thanks
Tejal

[gunadhya]

Hi @tejal29, So the output would look something like this : Deployments stabilized 3 seconds ago. Here's the doc example. Should I make the changes to other files in this format too?

[tejal29]

Hi @tejal29, So the output would look something like this : Deployments stabilized 3 seconds ago. Here's the doc example.

Thanks!

Should I make the changes to other files in this format too?

yes please.

[gunadhya]

I've made the changes as requested. Please do let me know if anything else seems broken or need fixing.

[tejal29]

this would make an excellent utility function so you don't have to repeat the code.

Suggested change

	if time.Since(start).Seconds() < 1 {
	showsTime = time.Since(start).String() + " ago"
	}
	logrus.Infoln("Ran", showsTime)
	logrus.Infoln("Ran", util.showHumanizeTime(start))

and

def showHumanizeTime(start time.Time) string {

showsTime := humanize.Time(start)
if time.Since(start).Seconds() < 1 {
	return  time.Since(start).String() + " ago"
}
return humanize.Time(start)
}

[gunadhya]

I've added a function in util and reworked its usage in the files.

[gunadhya]

I'm not sure why this test is failing? https://travis-ci.com/github/GoogleContainerTools/skaffold/jobs/464991267#L1013

[IsaacPD]

Everything looks good, just some changes to the test should be made.