Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AlecAivazis/survey to v2 #5129

Merged
merged 2 commits into from Dec 9, 2020

Conversation

MarlonGamez
Copy link
Contributor

Fixes #5114

Description
Bumps the version of https://github.com/AlecAivazis/survey to v2. The previously used version would allow for a situation where we dereference a nil pointer in skaffold init

The situation that would cause this is when the user is matching builders to images interactively, if they tried to filter by typing, but their search had no results and they hit enter anyway, it would effectively select nothing and return that value.

With the updated package, if the search returns nothing and they hit enter, nothing will happen. They will have to make a valid choice before moving on.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #5129 (c32826b) into master (113d9ac) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5129      +/-   ##
==========================================
- Coverage   72.27%   72.24%   -0.03%     
==========================================
  Files         380      380              
  Lines       13396    13396              
==========================================
- Hits         9682     9678       -4     
- Misses       3020     3022       +2     
- Partials      694      696       +2     
Impacted Files Coverage Δ
pkg/skaffold/initializer/prompt/prompt.go 0.00% <ø> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/server/server.go 45.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113d9ac...c32826b. Read the comment docs.

@MarlonGamez MarlonGamez marked this pull request as ready for review December 9, 2020 19:44
@MarlonGamez MarlonGamez requested a review from a team as a code owner December 9, 2020 19:44
Copy link
Contributor

@IsaacPD IsaacPD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally, and it all works as described!

@IsaacPD IsaacPD merged commit 6c7f33b into GoogleContainerTools:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold init: how to process after choosing the Dockerfiles?
2 participants