Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for creating metrics, fix bug related to unmarshalling flags #5169

Merged
merged 2 commits into from Dec 22, 2020

Conversation

IsaacPD
Copy link
Contributor

@IsaacPD IsaacPD commented Dec 18, 2020

Related: #5157
Merge after: #5168

Description

  • Fix bug by saving the flag value rather than the entire flag object
  • Assert that cloud monitoring exporter is not created if no keys/project id are provided
  • Compare the output created by the stdout exporter to what we expect should happen given the test skaffoldMeter structs provided.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #5169 (ae04b18) into master (531adb6) will increase coverage by 0.50%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5169      +/-   ##
==========================================
+ Coverage   71.91%   72.42%   +0.50%     
==========================================
  Files         385      385              
  Lines       13737    13735       -2     
==========================================
+ Hits         9879     9947      +68     
+ Misses       3128     3062      -66     
+ Partials      730      726       -4     
Impacted Files Coverage Δ
pkg/skaffold/instrumentation/meter.go 71.22% <93.33%> (+47.10%) ⬆️
pkg/skaffold/docker/image.go 80.93% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 531adb6...ae04b18. Read the comment docs.

@IsaacPD IsaacPD added the kokoro:force-run forces a kokoro re-run on a PR label Dec 18, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Dec 18, 2020
@IsaacPD IsaacPD merged commit 056bc1d into GoogleContainerTools:master Dec 22, 2020
@tejal29 tejal29 added the area/metrics Metrics tracking work for skaffold label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Metrics tracking work for skaffold cla: yes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants