Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag that prints timestamps in skaffold logs. #5181

Merged
merged 9 commits into from Dec 23, 2020

Conversation

jtzwu
Copy link
Contributor

@jtzwu jtzwu commented Dec 23, 2020

Description
Adds a flag that add timestamps to the skaffold logs.

User facing changes (remove if N/A)
Before

DEBU[0000] found config for context "minikube"          
DEBU[0000] could not parse date ""                      
DEBU[0000] Defaulting build type to local build         
INFO[0000] Using kubectl context: minikube        

After

DEBU[2020-12-22T17:05:27-08:00] found config for context "minikube"           
DEBU[2020-12-22T17:05:27-08:00] could not parse date ""                       
DEBU[2020-12-22T17:05:27-08:00] Defaulting build type to local build  

@jtzwu jtzwu requested a review from a team as a code owner December 23, 2020 01:06
@google-cla google-cla bot added the cla: yes label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5181 (996aef5) into master (056bc1d) will decrease coverage by 0.57%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5181      +/-   ##
==========================================
- Coverage   72.39%   71.82%   -0.58%     
==========================================
  Files         385      387       +2     
  Lines       13735    13928     +193     
==========================================
+ Hits         9944    10004      +60     
- Misses       3063     3190     +127     
- Partials      728      734       +6     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 67.40% <80.00%> (+0.99%) ⬆️
pkg/skaffold/diagnose/diagnose.go 15.15% <0.00%> (-39.40%) ⬇️
pkg/skaffold/build/dependencies.go 0.00% <0.00%> (-33.34%) ⬇️
pkg/skaffold/yaml/yaml.go 62.96% <0.00%> (-13.97%) ⬇️
pkg/skaffold/build/cache/lookup.go 80.00% <0.00%> (-7.88%) ⬇️
cmd/skaffold/app/cmd/test.go 46.66% <0.00%> (-7.18%) ⬇️
cmd/skaffold/app/cmd/deploy.go 56.52% <0.00%> (-5.39%) ⬇️
pkg/skaffold/test/test.go 86.79% <0.00%> (-5.37%) ⬇️
pkg/skaffold/runner/runcontext/context.go 79.27% <0.00%> (-5.34%) ⬇️
pkg/skaffold/errors/errors.go 86.95% <0.00%> (-4.35%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 056bc1d...996aef5. Read the comment docs.

@MarlonGamez
Copy link
Contributor

MarlonGamez commented Dec 23, 2020

hey @jtzwu, thanks for opening this PR. Looks like there's a formatting issue here but that's a quick fix. You'll also need to run ./hack/generate-man.sh and commit the results to update our docs to reflect the added flag. Thanks!

@MarlonGamez MarlonGamez added the kokoro:run runs the kokoro jobs on a PR label Dec 23, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Dec 23, 2020
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@MarlonGamez MarlonGamez merged commit 35214eb into GoogleContainerTools:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants