Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml encoders should be flushed. #5196

Merged
merged 1 commit into from Jan 7, 2021

Conversation

gsquared94
Copy link
Collaborator

From doc: The Encoder should be closed after use to flush all data to w.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #5196 (08c418c) into master (35214eb) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5196   +/-   ##
=======================================
  Coverage   71.82%   71.83%           
=======================================
  Files         387      387           
  Lines       13928    13932    +4     
=======================================
+ Hits        10004    10008    +4     
  Misses       3190     3190           
  Partials      734      734           
Impacted Files Coverage Δ
pkg/skaffold/yaml/yaml.go 54.83% <0.00%> (-8.13%) ⬇️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35214eb...08c418c. Read the comment docs.

@IsaacPD IsaacPD merged commit dc7b38d into GoogleContainerTools:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants