Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release automation changes #5203

Merged

Conversation

gsquared94
Copy link
Collaborator

This PR changes the github action trigger for release automation from PR with label 'draft-release' getting merged to commit with message 'release: vX.x.x' getting pushed. This solves 2 issues with current release automation:

  • Release PRs created from forks didn't work since the github action triggered by forks didn't have permissions to create tags. Changing the trigger to be based on 'commits on master' will work even when release PRs are created from forks.
  • Action triggered on PR merge was not repeatable manually in case of any error. Now we can simply push an empty commit if we want to retrigger the entire release pipeline again.

User facing changes:

Previously, in order to trigger the release pipeline, we required adding the draft-release label to the release PR and also Release vX.x.x be the PR title. Now we only require that the PR head commit be release: vX.x.x.

@gsquared94 gsquared94 requested a review from a team as a code owner January 5, 2021 17:20
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #5203 (5fdeb0d) into master (35214eb) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5203      +/-   ##
==========================================
+ Coverage   71.82%   71.87%   +0.05%     
==========================================
  Files         387      387              
  Lines       13928    13928              
==========================================
+ Hits        10004    10011       +7     
+ Misses       3190     3187       -3     
+ Partials      734      730       -4     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35214eb...5fdeb0d. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Jan 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 5, 2021
@MarlonGamez
Copy link
Contributor

This looks good imo, I think we can approve and merge once CI is fixed

@gsquared94
Copy link
Collaborator Author

Reran a few times to get a successful CI.

@nkubala nkubala merged commit 2dac367 into GoogleContainerTools:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants