Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Travis directive restricting builds to master #5219

Merged

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented Jan 12, 2021

The only-build-master directive prevents people from getting feedback on personal branches in forks, unless they are called master. This settings requires creating PRs for experimentation which causes noise, even if they are marked as draft.

This setting was originally brought it for #2607 to avoid merge failures from release branches. This PR instead uses a blocklist to prevent builds on release branches and version tags.

@briandealwis briandealwis requested a review from a team as a code owner January 12, 2021 03:03
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #5219 (fb42a29) into master (95092ad) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5219      +/-   ##
==========================================
+ Coverage   71.84%   71.87%   +0.02%     
==========================================
  Files         387      387              
  Lines       13974    13974              
==========================================
+ Hits        10040    10044       +4     
+ Misses       3195     3193       -2     
+ Partials      739      737       -2     
Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95092ad...fb42a29. Read the comment docs.

@gsquared94
Copy link
Collaborator

What I did was to add my fork to Travis directly. I think that approach is better than modifying this repo's settings. WDYT?
image

@briandealwis
Copy link
Member Author

I tried that, but Travis would only build if I pushed my branch to master. The description for the Building pushed branches setting notes:

Build pushed branches

If ON, builds will be run on branches that are not explicitly excluded in your .travis.yml.

I'll ping you tomorrow to compare settings tomorrow.

@briandealwis briandealwis changed the title Remove Travis directive to restrict builds to master Modify Travis directive restricting builds to master Jan 13, 2021
@briandealwis briandealwis merged commit 98faaaa into GoogleContainerTools:master Jan 13, 2021
@briandealwis briandealwis deleted the build-all-branches branch January 13, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants