Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MTU path discovery on Linux and setup registry-mirrors for kind #5237

Merged
merged 4 commits into from Jan 19, 2021

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented Jan 15, 2021

Third attempt is the charm!

See #5208 (comment) and #5221 for context.

@briandealwis briandealwis requested a review from a team as a code owner January 15, 2021 21:05
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #5237 (b3ac7ca) into master (98faaaa) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5237      +/-   ##
==========================================
- Coverage   71.87%   71.87%   -0.01%     
==========================================
  Files         387      388       +1     
  Lines       13974    14036      +62     
==========================================
+ Hits        10044    10088      +44     
- Misses       3193     3205      +12     
- Partials      737      743       +6     
Impacted Files Coverage Δ
pkg/skaffold/util/util.go 83.19% <0.00%> (-0.15%) ⬇️
pkg/skaffold/docker/docker_init.go 100.00% <0.00%> (ø)
pkg/skaffold/initializer/build/util.go 100.00% <0.00%> (ø)
pkg/skaffold/trigger/fsnotify/trigger.go 71.05% <0.00%> (ø)
pkg/skaffold/initializer/build/builders.go 70.00% <0.00%> (ø)
pkg/skaffold/initializer/analyze/builder.go 100.00% <0.00%> (ø)
pkg/skaffold/trigger/fsnotify/workdir.go
pkg/skaffold/tags/paths.go 65.00% <0.00%> (ø)
pkg/skaffold/util/workdir.go 20.00% <0.00%> (ø)
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98faaaa...b3ac7ca. Read the comment docs.

@briandealwis
Copy link
Member Author

Merging: I've re-run the build several times and it's come up green every time.

@briandealwis briandealwis merged commit 8c448c9 into GoogleContainerTools:master Jan 19, 2021
@briandealwis briandealwis deleted the reg branch January 19, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants