Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gcr.io/google-appengine/openjdk:8 to avoid toomanyrequests #5256

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

briandealwis
Copy link
Member

Change integration/testdata/debug/java/pom.xml to use gcr.io/google-appengine/openjdk:8 as the base image instead of openjdk from Docker Hub to avoid hitting Docker Hub rate limits.

@briandealwis briandealwis requested a review from a team as a code owner January 20, 2021 20:19
@google-cla google-cla bot added the cla: yes label Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #5256 (f63a0f3) into master (189701d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5256      +/-   ##
==========================================
- Coverage   71.92%   71.90%   -0.03%     
==========================================
  Files         388      388              
  Lines       14043    14043              
==========================================
- Hits        10101    10098       -3     
- Misses       3202     3203       +1     
- Partials      740      742       +2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 78.13% <0.00%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189701d...f63a0f3. Read the comment docs.

@briandealwis
Copy link
Member Author

Committing to reduce number of spurious test fails.

@briandealwis briandealwis merged commit e6b27a5 into GoogleContainerTools:master Jan 20, 2021
@briandealwis briandealwis deleted the openjdk branch January 20, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant