Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs with darwin/arm64 binaries #5287

Merged
merged 8 commits into from Feb 5, 2021
Merged

Update docs with darwin/arm64 binaries #5287

merged 8 commits into from Feb 5, 2021

Conversation

briandealwis
Copy link
Member

Fixes: #5042
Merge after: #5286

Description
Docs to add links for the darwin/arm64 binaries once they are being produced.

@google-cla google-cla bot added the cla: yes label Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021 •
edited

Codecov Report

Merging #5287 (1e4bb6e) into master (7b3d715) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5287   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files         394      394           
  Lines       14305    14305           
=======================================
  Hits        10240    10240           
  Misses       3309     3309           
  Partials      756      756

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3d715...1e4bb6e. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Feb 2, 2021
@briandealwis briandealwis added the kokoro:force-run forces a kokoro re-run on a PR label Feb 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Feb 4, 2021
@briandealwis briandealwis marked this pull request as ready for review February 4, 2021 21:59
@briandealwis briandealwis requested a review from a team as a code owner February 4, 2021 21:59
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 4, 2021
@IsaacPD IsaacPD added the docs-modifications runs the docs preview service on the given PR label Feb 4, 2021
@container-tools-bot
Copy link

Please visit http://34.94.250.235:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 4, 2021
IsaacPD
IsaacPD reviewed Feb 5, 2021
View reviewed changes
docs/content/en/docs/install/_index.md Outdated
Comment on lines 37 to 38
```
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a problem on the install page, I imagine from not putting a line in between the start of the other monospace block http://34.94.250.235:1313/docs/install/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh jeepers. That'll teach me for making a simple change without verifying.

@IsaacPD IsaacPD added the docs-modifications runs the docs preview service on the given PR label Feb 5, 2021
@container-tools-bot
Copy link

Please visit http://34.94.79.255:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 5, 2021
IsaacPD
IsaacPD approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@IsaacPD IsaacPD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There's a check failing because a new example got added ,#5325, but not in time for #5279

@IsaacPD IsaacPD merged commit 7af9979 into GoogleContainerTools:master Feb 5, 2021
@fmotrifork fmotrifork mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacPD IsaacPD IsaacPD approved these changes

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish macOS/arm64 binaries
4 participants
@briandealwis @container-tools-bot @IsaacPD @kokoro-team