Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pulling secrets in cloudbuild release for latest builds #5328

Merged
merged 1 commit into from Feb 1, 2021

Conversation

IsaacPD
Copy link
Contributor

@IsaacPD IsaacPD commented Feb 1, 2021

Related: #5314

Description
Applies the changes of cloudbuild-release.yaml in #5314 to cloudbuild.yaml to fix the "Skaffold latest build" trigger. This trigger keeps failing with

Starting Step #0
Step #0: Already have image (with digest): gcr.io/cloud-builders/gsutil
Step #0: CommandException: Destination URL must name a directory, bucket, or bucket
Step #0: subdirectory for the multiple source form of the cp command.
Finished Step #0
ERROR
ERROR: build step 0 "gcr.io/cloud-builders/gsutil" failed: step exited with non-zero status: 1

since it was not modified to properly pull the keys from the gcs bucket. Uses deploy/setup-secret.sh instead to pull the secret.

@IsaacPD IsaacPD requested a review from a team as a code owner February 1, 2021 16:04
@google-cla google-cla bot added the cla: yes label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #5328 (68a2526) into master (7a326e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5328   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files         390      390           
  Lines       14215    14215           
=======================================
  Hits        10206    10206           
  Misses       3257     3257           
  Partials      752      752           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a326e6...68a2526. Read the comment docs.

@tejal29 tejal29 merged commit 0247608 into GoogleContainerTools:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants