Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide --auto-{build,deploy,sync} and update debug notes #5347

Merged
merged 2 commits into from Feb 4, 2021

Conversation

briandealwis
Copy link
Member

Description

This PR:

  1. Unhides the --auto-sync, --auto-build, and --auto-deploy flags for dev and debug.
  2. Adds a note about these flags to the debug command helper.
  3. Adds a note about these flags to the debug docs.

User facing changes (remove if N/A)

  • skaffold dev and skaffold debug support --auto-build, --auto-deploy, and --auto-sync to control how Skaffold reacts to file changes during a development session.

@briandealwis briandealwis requested a review from a team as a code owner February 3, 2021 22:57
@google-cla google-cla bot added the cla: yes label Feb 3, 2021
Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #5347 (e649e3f) into master (c254d25) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5347      +/-   ##
==========================================
+ Coverage   71.80%   71.83%   +0.02%     
==========================================
  Files         392      392              
  Lines       14228    14230       +2     
==========================================
+ Hits        10217    10222       +5     
+ Misses       3259     3258       -1     
+ Partials      752      750       -2     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 87.50% <ø> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c254d25...e649e3f. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@briandealwis briandealwis merged commit 1f4b538 into GoogleContainerTools:master Feb 4, 2021
@briandealwis briandealwis deleted the unhide-auto branch February 4, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants