Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use status code string in error label #5350

Merged

Conversation

IsaacPD
Copy link
Contributor

@IsaacPD IsaacPD commented Feb 4, 2021

Fixes: #5349

Description
Changed all instances of meter.ErrorCode to meter.ErrorCode.String()

@IsaacPD IsaacPD requested a review from a team as a code owner February 4, 2021 17:33
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #5350 (1a87ef4) into master (8159a13) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5350      +/-   ##
==========================================
- Coverage   71.84%   71.61%   -0.24%     
==========================================
  Files         392      394       +2     
  Lines       14231    14305      +74     
==========================================
+ Hits        10224    10244      +20     
- Misses       3257     3307      +50     
- Partials      750      754       +4     
Impacted Files Coverage Δ
pkg/skaffold/instrumentation/export.go 76.56% <100.00%> (ø)
pkg/skaffold/schema/versions.go 82.41% <0.00%> (ø)
pkg/skaffold/schema/v2beta11/upgrade.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/v2beta11/config.go 20.58% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8159a13...1a87ef4. Read the comment docs.

@MarlonGamez
Copy link
Contributor

Looks like this needs a rebase but looks good! I can approve and merge when that's done

@MarlonGamez MarlonGamez merged commit 3764e1f into GoogleContainerTools:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Status Code name instead of number in our error metrics
2 participants