Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to fix getCPUInfo error on darwin/arm64 #5351

Merged
merged 1 commit into from Feb 4, 2021

Conversation

briandealwis
Copy link
Member

Towards: #5042

Description

Unpin containerd/containerd and update dependencies. This fixes the (spurious) error seen on start on darwin/amd64:

$ skaffold dev
ERRO[0000] failure getting variant                       error="getCPUInfo for OS darwin: not implemented"
...

@briandealwis briandealwis requested a review from a team as a code owner February 4, 2021 18:24
@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #5351 (aeecbad) into master (e348f56) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5351      +/-   ##
==========================================
+ Coverage   71.83%   71.85%   +0.02%     
==========================================
  Files         392      392              
  Lines       14228    14228              
==========================================
+ Hits        10221    10224       +3     
+ Misses       3257     3256       -1     
+ Partials      750      748       -2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e348f56...aeecbad. Read the comment docs.

@briandealwis briandealwis merged commit 8ad4f68 into GoogleContainerTools:master Feb 4, 2021
@briandealwis briandealwis deleted the cpuinfo branch February 4, 2021 21:08
briandealwis added a commit that referenced this pull request Feb 8, 2021
Alternative form of #5351 to minimize dependency churn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants