Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document steps to use sErrors.ErrDef class to provide actionable error messages #5375

Merged
merged 2 commits into from Feb 9, 2021

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Feb 9, 2021

Documented steps for contributors to add distinct error codes.

These steps are written from discussion captured here.
e.g. #5088 (comment)

Please review changes to doc here http://34.94.21.130:1313/docs/references/api/grpc/#statuscode
Changes to Makefile: https://github.com/GoogleContainerTools/skaffold/pull/5375/files?short_path=fc2a310#diff-fc2a310fcfedfefb0046def697f932def80cbb1e78c689bc0af3c8eab3e33ece

Thanks
Tejal

@tejal29 tejal29 requested a review from a team as a code owner February 9, 2021 00:27
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@tejal29
Copy link
Member Author

tejal29 commented Feb 9, 2021

/cc @TBBle

@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Feb 9, 2021
@container-tools-bot
Copy link

Please visit http://34.94.21.130:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #5375 (03114a1) into master (3764e1f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5375      +/-   ##
==========================================
+ Coverage   71.61%   71.63%   +0.02%     
==========================================
  Files         394      394              
  Lines       14305    14305              
==========================================
+ Hits        10244    10247       +3     
+ Misses       3307     3306       -1     
+ Partials      754      752       -2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3764e1f...03114a1. Read the comment docs.

@gsquared94 gsquared94 merged commit e52a22a into GoogleContainerTools:master Feb 9, 2021
@tejal29 tejal29 deleted the add_err_codes branch July 21, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants