Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error codes for structure test failures #5385

Merged
merged 3 commits into from Feb 11, 2021

Conversation

PriyaModali
Copy link
Contributor

@PriyaModali PriyaModali commented Feb 10, 2021

Fixes: #5384

Description
Adding error codes for test failures

User facing changes
These changes will enable Skaffold dev to return distinct error codes when tests fail.

There are no visible user facing changes.

Related:
#5333

@PriyaModali PriyaModali requested a review from a team as a code owner February 10, 2021 23:06
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #5385 (ea56a7f) into master (0ba3ee7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5385   +/-   ##
=======================================
  Coverage   71.55%   71.56%           
=======================================
  Files         395      397    +2     
  Lines       14409    14427   +18     
=======================================
+ Hits        10310    10324   +14     
- Misses       3333     3335    +2     
- Partials      766      768    +2     
Impacted Files Coverage Δ
pkg/skaffold/test/error.go 100.00% <100.00%> (ø)
pkg/skaffold/test/structure/error.go 100.00% <100.00%> (ø)
pkg/skaffold/test/structure/structure.go 100.00% <100.00%> (ø)
pkg/skaffold/test/test.go 86.79% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba3ee7...ea56a7f. Read the comment docs.

@PriyaModali PriyaModali merged commit 607eedc into GoogleContainerTools:master Feb 11, 2021
@PriyaModali PriyaModali changed the title Add error codes for test failures Add error codes for structure test failures Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add distinct error codes for structure test failures
2 participants