Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absolute path substitution in configs imported as dependencies. #5389

Merged
merged 3 commits into from Feb 11, 2021
Merged

Fix absolute path substitution in configs imported as dependencies. #5389

merged 3 commits into from Feb 11, 2021

Conversation

gsquared94
Copy link
Collaborator

Fixes #5388

@gsquared94 gsquared94 requested a review from a team as a code owner February 11, 2021 18:53
@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021 •
edited

Codecov Report

Merging #5389 (75a1747) into master (607eedc) will decrease coverage by 0.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5389      +/-   ##
==========================================
- Coverage   71.58%   71.57%   -0.02%     
==========================================
  Files         397      397              
  Lines       14427    14433       +6     
==========================================
+ Hits        10328    10330       +2     
- Misses       3333     3335       +2     
- Partials      766      768       +2
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 58.82% <ø> (ø)
cmd/skaffold/app/cmd/parse_config.go 71.42% <81.81%> (+1.61%) ⬆️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607eedc...75a1747. Read the comment docs.

@gsquared94 gsquared94 merged commit e3bffea into GoogleContainerTools:master Feb 11, 2021
@fmotrifork fmotrifork mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

Assignees
No one assigned
Labels
cla: yes feature/multi-configs size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Artifact workspace and other filepath type fields not being set correctly in configs imported as dependencies
2 participants
@gsquared94 @nkubala