Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit error codes for various config parsing errors #5483

Merged
merged 4 commits into from Mar 9, 2021

Conversation

gsquared94
Copy link
Collaborator

@gsquared94 gsquared94 commented Mar 3, 2021

Fixes #5412

This PR adds specific failure error codes and appropriate suggestion text via ActionableErrors for skaffold's config parsing step.

@gsquared94 gsquared94 requested a review from tejal29 March 3, 2021 07:13
@gsquared94 gsquared94 requested a review from a team as a code owner March 3, 2021 07:13
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@gsquared94 gsquared94 added this to the v1.21.0 milestone Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #5483 (e173475) into master (2cc744d) will increase coverage by 0.18%.
The diff coverage is 92.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5483      +/-   ##
==========================================
+ Coverage   71.46%   71.65%   +0.18%     
==========================================
  Files         398      399       +1     
  Lines       14641    14739      +98     
==========================================
+ Hits        10463    10561      +98     
  Misses       3402     3402              
  Partials      776      776              
Impacted Files Coverage Δ
pkg/skaffold/parser/config.go 78.68% <46.66%> (ø)
cmd/skaffold/app/cmd/runner.go 60.71% <100.00%> (+0.71%) ⬆️
pkg/skaffold/schema/errors/errors.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc744d...e173475. Read the comment docs.

@MarlonGamez
Copy link
Contributor

hey @gsquared94 , my PR that separates enum definitions into their own file got merged, would you be able to move your enum definitions into proto/enums/enums.proto?

@gsquared94 gsquared94 merged commit 1c4435b into GoogleContainerTools:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create specific error codes for various skaffold config parsing errors
3 participants