Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom build example #5495

Merged
merged 2 commits into from Mar 7, 2021

Conversation

PriyaModali
Copy link
Contributor

Fixes: #5492
Description
Make custom build example functional

Custom build example is currently broken. It needs to be fixed.

User facing changes
Before:

skaffold dev

Listing files to watch...
 - ko://github.com/GoogleContainerTools/skaffold/examples/custom
Generating tags...
 - ko://github.com/GoogleContainerTools/skaffold/examples/custom -> ko://github.com/GoogleContainerTools/skaffold/examples/custom:latest
Checking cache...
 - ko://github.com/GoogleContainerTools/skaffold/examples/custom: Error checking cache.
exiting dev mode because first build failed: getting imageID for ko://github.com/GoogleContainerTools/skaffold/examples/custom:latest: Error response from daemon: no such image: ko:/github.com/GoogleContainerTools/skaffold/examples/custom:latest: invalid reference format: repository name must be lowercase

After:

skaffold dev

 Listing files to watch...
 - github.com/googlecontainertools/skaffold/examples/custom
Generating tags...
 - github.com/googlecontainertools/skaffold/examples/custom -> github.com/googlecontainertools/skaffold/examples/custom:latest
Checking cache...
 - github.com/googlecontainertools/skaffold/examples/custom: Found Locally
Tags used in deployment:
 - github.com/googlecontainertools/skaffold/examples/custom -> github.com/googlecontainertools/skaffold/examples/custom:5ed1d68f2edf26a699842fbf3920fe964450e8bc714d4a2f4d0f307afa018bc7
Starting deploy...
 - pod/getting-started created
Waiting for deployments to stabilize...
Deployments stabilized in 49.503924ms
Press Ctrl+C to exit
Watching for changes...
[getting-started] Hello world!
[getting-started] Hello world!
[getting-started] Hello world!

@PriyaModali PriyaModali added kind/bug Something isn't working priority/p2 May take a couple of releases labels Mar 5, 2021
@PriyaModali PriyaModali requested a review from a team as a code owner March 5, 2021 15:00
@google-cla google-cla bot added the cla: yes label Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #5495 (a5b9483) into master (2e55bec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5495   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files         398      398           
  Lines       14654    14654           
=======================================
  Hits        10467    10467           
  Misses       3409     3409           
  Partials      778      778           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e55bec...a5b9483. Read the comment docs.

@PriyaModali PriyaModali added the kokoro:force-run forces a kokoro re-run on a PR label Mar 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 5, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested locally and seems to work. I think we may have an issue with a code path not being hit. Left a comment on the linked issue

@PriyaModali PriyaModali merged commit 82a5eb1 into GoogleContainerTools:master Mar 7, 2021
@briandealwis
Copy link
Member

This isn't right: Skaffold has special treatment for ko: image references (#4952).

@PriyaModali
Copy link
Contributor Author

PriyaModali commented Mar 8, 2021

This example was broken as the ko: / SanitizeImageName feature doesn't work properly now. Will revisit the example once the feature has been implemented properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes kind/bug Something isn't working priority/p2 May take a couple of releases size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ko:// image references are broken
4 participants