Add 'skaffold apply' command #5543

nkubala · 2021-03-12T19:57:09Z

This change adds a new command, skaffold apply, which accepts one or more hydrated Kubernetes manifests and uses them to create resources on the cluster.

skaffold apply does not perform any build actions (skaffold build), and does not perform any configuration management (skaffold render): it instead blindly consumes whatever Kubernetes configuration it is passed and sends it to kubectl. It will, however, monitor resource status through the built-in status-check mechanism.

This command unlocks the ability for Skaffold to consume its own output from skaffold render:

➜ (getting-started) skaffold render --output render.yaml

➜  (getting-started) cat render.yaml 
apiVersion: v1
kind: Pod
metadata:
  name: getting-started
  namespace: default
spec:
  containers:
  - image: skaffold-example:99e5f4d45e86d2aa180ebb6d382015d43383fef1ed7efcfff1a61fd205421479
    name: getting-started

➜ (getting-started) skaffold apply render.yaml
 - pod/getting-started created
Waiting for deployments to stabilize...
Deployments stabilized in 43.504125ms

Skaffold labels skaffold.dev/run-id and kubernetes.io/managed-by will be added to all deployed resources since they are required by the status checker. cc #5542

To be merged after #5541 - please review that PR first, and this change will be rebased for ease of review once that PR is merged.

Part 2 / Fixes #4856

codecov · 2021-03-12T20:27:15Z

Codecov Report

Merging #5543 (657a131) into master (ef86216) will decrease coverage by 0.15%.
The diff coverage is 23.28%.

@@            Coverage Diff             @@
##           master    #5543      +/-   ##
==========================================
- Coverage   71.22%   71.07%   -0.16%     
==========================================
  Files         400      402       +2     
  Lines       14934    15055     +121     
==========================================
+ Hits        10637    10700      +63     
- Misses       3510     3563      +53     
- Partials      787      792       +5

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/flags.go	`88.88% <ø> (+0.95%)`	⬆️
pkg/skaffold/config/options.go	`100.00% <ø> (ø)`
pkg/skaffold/deploy/kubectl/cli.go	`87.50% <ø> (ø)`
pkg/skaffold/runner/apply.go	`0.00% <0.00%> (ø)`
pkg/skaffold/runner/new.go	`63.13% <0.00%> (ø)`
pkg/skaffold/runner/runner.go	`0.00% <ø> (ø)`
cmd/skaffold/app/cmd/apply.go	`25.00% <25.00%> (ø)`
cmd/skaffold/app/cmd/commands.go	`81.25% <28.57%> (-9.00%)`	⬇️
pkg/skaffold/deploy/kubectl/kubectl.go	`65.18% <50.00%> (-1.48%)`	⬇️
cmd/skaffold/app/cmd/cmd.go	`63.29% <100.00%> (+0.23%)`	⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef86216...657a131. Read the comment docs.

gsquared94 · 2021-03-12T20:48:37Z

cmd/skaffold/app/cmd/apply.go

+		}, doApply)
+}
+
+func doApply(ctx context.Context, out io.Writer, args []string) error {


should you allow glob arguments like kubectl deployer currently does?

should we support urls?

should we support reading from STDIN so I could do this 😅:
In examples/multi-config-microservices

skaffold diagnose --yaml-only | skaffold render -f - | skaffold apply -

haha yes these are all great suggestions 😄 i think i'm fine with supporting all 3 of these, but how about i add them in a follow up PR? they seem like QOL enhancements to this feature

nkubala · 2021-03-12T21:18:15Z

forgot to mention, docs are on their way

cmd/skaffold/app/cmd/apply.go

briandealwis

I removed some passive voice

docs/content/en/docs/workflows/ci-cd.md

Co-authored-by: Brian de Alwis <bsd@acm.org>

nkubala · 2021-03-17T19:07:34Z

CI is failing because of a docker rate limit issue:

RUN hack/test-generated-proto.sh
Sending build context to Docker daemon  435.8kB
Step 1/33 : FROM golang:1.13.4-alpine3.10 AS generate-files
1.13.4-alpine3.10: Pulling from library/golang
anyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Unable to find image 'gen-proto:latest' locally
docker: Error response from daemon: pull access denied for gen-proto, repository does not exist or may require 'docker login'.
See 'docker run --help'.
Generated proto files aren't updated. Please run ./hack/generate-proto.sh
FAILED hack/test-generated-proto.sh

nkubala · 2021-03-17T20:08:55Z

codecov is reporting some very strange results: https://app.codecov.io/gh/GoogleContainerTools/skaffold/compare/5543/changes

going to self-merge since the rest of CI is green.

nkubala requested a review from a team as a code owner March 12, 2021 19:57

pull-request-size bot added the size/L label Mar 12, 2021

google-cla bot added the cla: yes label Mar 12, 2021

nkubala changed the title ~~Apply command~~ Add 'skaffold apply' command Mar 12, 2021

nkubala force-pushed the apply-command branch from 7b4f111 to 8604bb5 Compare March 12, 2021 20:02

pull-request-size bot added size/XL and removed size/L labels Mar 12, 2021

nkubala force-pushed the apply-command branch 2 times, most recently from 93620ed to e72ebcc Compare March 12, 2021 20:14

gsquared94 reviewed Mar 12, 2021

View reviewed changes

nkubala force-pushed the apply-command branch from e72ebcc to 2d6cf4a Compare March 12, 2021 23:35

pull-request-size bot added size/L and removed size/XL labels Mar 12, 2021

Add 'skaffold apply' command

f0118e4

nkubala force-pushed the apply-command branch from 2d6cf4a to f0118e4 Compare March 12, 2021 23:42

briandealwis reviewed Mar 15, 2021

View reviewed changes

cmd/skaffold/app/cmd/apply.go Show resolved Hide resolved

nkubala and others added 2 commits March 16, 2021 10:26

add apply to instrumented commands

bb9083d

add docs

4021aeb

briandealwis approved these changes Mar 17, 2021

View reviewed changes

nkubala and others added 5 commits March 17, 2021 09:51

Update docs/content/en/docs/workflows/ci-cd.md

dbedd2a

Co-authored-by: Brian de Alwis <bsd@acm.org>

Update docs/content/en/docs/workflows/ci-cd.md

ec8184c

Co-authored-by: Brian de Alwis <bsd@acm.org>

Update docs/content/en/docs/workflows/ci-cd.md

2037499

Co-authored-by: Brian de Alwis <bsd@acm.org>

Update docs/content/en/docs/workflows/ci-cd.md

8391ff3

Co-authored-by: Brian de Alwis <bsd@acm.org>

docs updates

657a131

nkubala merged commit 5bf0323 into GoogleContainerTools:master Mar 17, 2021

gofish-bot mentioned this pull request Mar 19, 2021

skaffold 1.21.0 fishworks/fish-food#1297

Merged

nkubala mentioned this pull request May 3, 2021

Use default deployer in 'skaffold apply' #5776

Merged

nkubala deleted the apply-command branch June 17, 2021 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'skaffold apply' command #5543

Add 'skaffold apply' command #5543

nkubala commented Mar 12, 2021

codecov bot commented Mar 12, 2021 •

edited

gsquared94 Mar 12, 2021

gsquared94 Mar 12, 2021

gsquared94 Mar 12, 2021

nkubala Mar 12, 2021

nkubala commented Mar 12, 2021

briandealwis left a comment

nkubala commented Mar 17, 2021

nkubala commented Mar 17, 2021

Add 'skaffold apply' command #5543

Add 'skaffold apply' command #5543

Conversation

nkubala commented Mar 12, 2021

codecov bot commented Mar 12, 2021 • edited

Codecov Report

gsquared94 Mar 12, 2021

Choose a reason for hiding this comment

gsquared94 Mar 12, 2021

Choose a reason for hiding this comment

gsquared94 Mar 12, 2021

Choose a reason for hiding this comment

nkubala Mar 12, 2021

Choose a reason for hiding this comment

nkubala commented Mar 12, 2021

briandealwis left a comment

Choose a reason for hiding this comment

nkubala commented Mar 17, 2021

nkubala commented Mar 17, 2021

codecov bot commented Mar 12, 2021 •

edited