Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _index.md #5752

Merged
merged 2 commits into from May 5, 2021
Merged

Conversation

joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Apr 29, 2021

Description
Do not specify the exact number of skaffold stages. The currently specified number does not agree with the diagram or subsequent table, and is likely to change.

I know. Nobody expects the Spanish Inquisition.

Amongst our stages are ...

I know. Nobody expects the Spanish Inquisition.

Amongst our stages are ...
@joebowbeer joebowbeer requested a review from a team as a code owner April 29, 2021 15:17
@joebowbeer joebowbeer requested a review from nkubala April 29, 2021 15:17
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #5752 (6140d7a) into master (4106c53) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5752      +/-   ##
==========================================
- Coverage   70.87%   70.74%   -0.13%     
==========================================
  Files         421      433      +12     
  Lines       16087    16256     +169     
==========================================
+ Hits        11401    11501     +100     
- Misses       3850     3908      +58     
- Partials      836      847      +11     
Impacted Files Coverage Δ
pkg/skaffold/build/jib/init.go 83.05% <0.00%> (-4.45%) ⬇️
cmd/skaffold/app/cmd/render.go 44.44% <0.00%> (-1.99%) ⬇️
cmd/skaffold/app/cmd/runner.go 58.49% <0.00%> (-1.51%) ⬇️
pkg/skaffold/build/jib/jib.go 69.46% <0.00%> (-1.08%) ⬇️
pkg/skaffold/runner/deploy.go 53.00% <0.00%> (-0.61%) ⬇️
pkg/skaffold/runner/runcontext/context.go 84.17% <0.00%> (-0.58%) ⬇️
pkg/skaffold/schema/versions.go 82.41% <0.00%> (ø)
pkg/skaffold/instrumentation/export.go 73.10% <0.00%> (ø)
pkg/skaffold/kubernetes/colorpicker.go 100.00% <0.00%> (ø)
pkg/skaffold/schema/latest/v1/config.go 58.82% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4106c53...6140d7a. Read the comment docs.

@briandealwis
Copy link
Member

Ha! Thanks for noticing. Definitely needs @nkubala's input because I'm not sure if we're counting the blue squares or all squares.

@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Apr 29, 2021
@container-tools-bot
Copy link

Please visit http://35.236.94.72:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 29, 2021
@joebowbeer
Copy link
Contributor Author

joebowbeer commented Apr 30, 2021

@briandealwis In addition to the initial diagram, which has 7+2 stages, there is also the table of Skaffold Pipeline stages at the bottom of the page, which has nine rows - but maybe Init shouldn't be counted.

By the way, elsewhere (api.md), the doc refers to the phases of the pipeline as build, deploy, and sync.

@nkubala
Copy link
Contributor

nkubala commented May 3, 2021

@joebowbeer lol nice catch :) to be honest our diagrams are getting stale and might need to be updated in the future. I wonder if we should just say multi-stage workflow so we don't have to keep updating that string?

@nkubala
Copy link
Contributor

nkubala commented May 3, 2021

also worth mentioning that as a team we collectively agree our docs need lots of love - this is yet another item to add to the list of things to address

s/nine/multi/
@joebowbeer
Copy link
Contributor Author

@nkubala I applied your multi-stage suggestion.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label May 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 4, 2021
@gsquared94 gsquared94 merged commit 3fe197f into GoogleContainerTools:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants