Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold diagnose to not initialize runconfig for yaml only flag #5762

Merged
merged 5 commits into from Apr 30, 2021

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Apr 30, 2021

Fixes #5701

In this PR the code is refactored to make sure we don't create a skaffold RunContext object when skaffold diagnose is run with --yaml-only flag.

@tejal29 tejal29 requested a review from a team as a code owner April 30, 2021 00:06
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@tejal29 tejal29 force-pushed the fix_diagnose branch 2 times, most recently from 7a1957e to f6b5200 Compare April 30, 2021 00:13
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #5762 (50836aa) into master (21e3c95) will decrease coverage by 0.19%.
The diff coverage is 33.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5762      +/-   ##
==========================================
- Coverage   70.89%   70.70%   -0.20%     
==========================================
  Files         421      427       +6     
  Lines       16091    16181      +90     
==========================================
+ Hits        11408    11441      +33     
- Misses       3849     3899      +50     
- Partials      834      841       +7     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 58.82% <ø> (ø)
pkg/skaffold/schema/v2beta14/upgrade.go 100.00% <ø> (ø)
pkg/skaffold/schema/versions.go 82.41% <ø> (ø)
pkg/skaffold/schema/v2beta15/config.go 20.58% <20.58%> (ø)
cmd/skaffold/app/cmd/diagnose.go 63.33% <50.00%> (+30.00%) ⬆️
cmd/skaffold/app/cmd/runner.go 58.49% <100.00%> (-1.51%) ⬇️
pkg/skaffold/runner/runcontext/context.go 85.12% <100.00%> (+0.37%) ⬆️
pkg/skaffold/schema/v2beta15/upgrade.go 100.00% <100.00%> (ø)
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789d058...50836aa. Read the comment docs.

@tejal29 tejal29 merged commit 08f0a60 into GoogleContainerTools:master Apr 30, 2021
@tejal29 tejal29 deleted the fix_diagnose branch July 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold diagnose breaks when minikube is paused and docker is force quit
2 participants