Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make completion work again #6138

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

briandealwis
Copy link
Member

Fixes: #5960

This PR prevents redirecting output for the internal spf13/cobra commands used for handling completion support. Use cmd.Name() as cmd.Use has [command-line] appended to the name for these internal commands.

@briandealwis briandealwis requested a review from a team as a code owner July 6, 2021 16:01
@google-cla google-cla bot added the cla: yes label Jul 6, 2021
Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #6138 (005a6a5) into master (823896b) will increase coverage by 0.00%.
The diff coverage is 35.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6138   +/-   ##
=======================================
  Coverage   69.94%   69.95%           
=======================================
  Files         478      478           
  Lines       18286    18287    +1     
=======================================
+ Hits        12791    12793    +2     
  Misses       4548     4548           
+ Partials      947      946    -1     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 68.75% <35.71%> (+0.17%) ⬆️
pkg/skaffold/util/tar.go 50.66% <0.00%> (-5.34%) ⬇️
pkg/skaffold/docker/parse.go 87.14% <0.00%> (+0.95%) ⬆️
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823896b...005a6a5. Read the comment docs.

@briandealwis briandealwis merged commit 2d766a1 into GoogleContainerTools:master Jul 7, 2021
@briandealwis briandealwis deleted the i5960 branch July 7, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold zsh command completion ends with ShellCompDirectiveNoFileComp
2 participants