Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added template expansion for helm chart version (#5709) #6157

Merged
merged 5 commits into from
Jul 12, 2021

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented Jul 7, 2021

Signed-off-by: Pablo Caderno kaderno@gmail.com

Fixes: #5709
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

Added template expansion for Helm chart version.

Before (no variable expansion):

initial

After (it uses the value):
final

If variable is not defined:
Screenshot from 2021-07-08 08-35-10

@kadern0 kadern0 requested a review from a team as a code owner July 7, 2021 22:44
@kadern0 kadern0 requested a review from briandealwis July 7, 2021 22:44
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #6157 (4774833) into master (62a01f6) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6157      +/-   ##
==========================================
- Coverage   71.12%   71.09%   -0.03%     
==========================================
  Files         483      483              
  Lines       21549    21553       +4     
==========================================
- Hits        15326    15323       -3     
- Misses       5246     5249       +3     
- Partials      977      981       +4     
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm/deploy.go 76.87% <66.66%> (-0.38%) ⬇️
pkg/skaffold/deploy/helm/args.go 83.19% <100.00%> (ø)
pkg/skaffold/util/tar.go 52.87% <0.00%> (-4.60%) ⬇️
pkg/skaffold/docker/image.go 80.08% <0.00%> (-1.22%) ⬇️
pkg/skaffold/docker/parse.go 88.23% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a01f6...4774833. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kadern0! I'll make the change I suggested below and added a quick test for verification.

pkg/skaffold/deploy/helm/args.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot removed the size/S label Jul 9, 2021
@google-cla

This comment has been minimized.

@google-cla google-cla bot removed the cla: yes label Jul 9, 2021
@google-cla google-cla bot added the cla: no label Jul 9, 2021
@briandealwis
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 9, 2021
@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label Jul 9, 2021
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 9, 2021
@briandealwis briandealwis enabled auto-merge (squash) July 9, 2021 21:18
@kadern0
Copy link
Contributor Author

kadern0 commented Jul 11, 2021

Thanks @kadern0! I'll make the change I suggested below and added a quick test for verification.

Thanks :)

@briandealwis briandealwis added the kokoro:force-run forces a kokoro re-run on a PR label Jul 12, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jul 12, 2021
@briandealwis briandealwis merged commit 12e9772 into GoogleContainerTools:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use environment variable for helm release version
4 participants