Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate kaniko environment to GCB #6181

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

briandealwis
Copy link
Member

Fixes: #6174

@briandealwis briandealwis requested a review from tejal29 July 9, 2021 21:49
@briandealwis briandealwis requested a review from a team as a code owner July 9, 2021 21:49
@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@briandealwis briandealwis enabled auto-merge (squash) July 10, 2021 02:59
@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #6181 (4342a84) into master (37cdc30) will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6181      +/-   ##
==========================================
+ Coverage   71.06%   71.08%   +0.01%     
==========================================
  Files         482      482              
  Lines       21517    21526       +9     
==========================================
+ Hits        15291    15301      +10     
  Misses       5247     5247              
+ Partials      979      978       -1     
Impacted Files Coverage Δ
pkg/skaffold/build/gcb/kaniko.go 76.00% <77.77%> (+1.00%) ⬆️
pkg/skaffold/docker/image.go 81.30% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cdc30...4342a84. Read the comment docs.

@briandealwis briandealwis merged commit 5848b66 into GoogleContainerTools:master Jul 12, 2021
@briandealwis briandealwis deleted the i6174 branch July 12, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env param is not passed to kaniko pod.
2 participants