refactor: Read globalConfig instead of kubecontext config for survey config #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6191 +/- ##
=======================================
Coverage 71.08% 71.08%
=======================================
Files 485 485
Lines 21603 21607 +4
=======================================
+ Hits 15356 15360 +4
Misses 5264 5264
Partials 983 983
Continue to review full report at Codecov.
|
tejal29
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to epic issue #6166
relates to #6189
However not completely fixes it. We still need to revisit all occurrences of
GetConfigForCurrentKubectxand maybe remove them.Also note, we only update global config for all survey fields.
skaffold/pkg/skaffold/survey/survey.go
Line 101 in db90d38