Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove note on vendor/ usage from DEVELOPMENT.md #6422

Merged
merged 1 commit into from Aug 12, 2021
Merged

remove note on vendor/ usage from DEVELOPMENT.md #6422

merged 1 commit into from Aug 12, 2021

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Aug 12, 2021

It does not seem the project vendors the dependencies anymore, so the notice
in DEVELOPMENT GUIDE does not seem relevant anymore.

It does not seem the project vendors the dependencies anymore, so the notice
in DEVELOPMENT GUIDE does not seem relevant anymore.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb requested a review from a team as a code owner August 12, 2021 20:28
@ahmetb ahmetb requested a review from tejal29 August 12, 2021 20:28
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #6422 (4e7d7b7) into main (e6a7a03) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6422      +/-   ##
==========================================
- Coverage   70.41%   70.40%   -0.02%     
==========================================
  Files         505      505              
  Lines       22840    22840              
==========================================
- Hits        16083    16080       -3     
- Misses       5705     5708       +3     
  Partials     1052     1052              
Impacted Files Coverage Δ
pkg/skaffold/log/stream/stream.go 71.42% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a7a03...4e7d7b7. Read the comment docs.

@tejal29 tejal29 merged commit be104a1 into GoogleContainerTools:main Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants