Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording describing how profiles work #6445

Merged
merged 1 commit into from Aug 20, 2021

Conversation

MarlonGamez
Copy link
Contributor

Related: #5869

Description
This PR changes some of the wording used when describing how profile activation works.

@MarlonGamez
Copy link
Contributor Author

Should I add an example to showcase how exactly this might cause issues for the user? Like #5869 ?

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #6445 (c50955e) into main (9535940) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6445      +/-   ##
==========================================
+ Coverage   70.40%   70.42%   +0.02%     
==========================================
  Files         505      505              
  Lines       22840    22840              
==========================================
+ Hits        16080    16086       +6     
+ Misses       5708     5704       -4     
+ Partials     1052     1050       -2     
Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 66.55% <0.00%> (+0.99%) ⬆️
pkg/skaffold/log/stream/stream.go 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9535940...c50955e. Read the comment docs.

@tejal29
Copy link
Member

tejal29 commented Aug 16, 2021

Should I add an example to showcase how exactly this might cause issues for the user? Like #5869 ?

You could say something like "To completely replace a config section see " and point to the Json Patch example below

@MarlonGamez MarlonGamez merged commit 7d7de48 into GoogleContainerTools:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants