Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not sync remote configs for specific commands #6453

Merged
merged 2 commits into from Aug 23, 2021

Conversation

gsquared94
Copy link
Collaborator

Description

In #6210 we added the flag sync-remote-cache. This PR changes the default value of this flag to missing for the commands inspect, diagnose and fix. This will speed up these commands for projects using remote skaffold modules.

@gsquared94 gsquared94 requested a review from a team as a code owner August 18, 2021 05:17
@google-cla google-cla bot added the cla: yes label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #6453 (c899332) into main (6463b24) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6453      +/-   ##
==========================================
+ Coverage   70.27%   70.28%   +0.01%     
==========================================
  Files         510      510              
  Lines       22976    22976              
==========================================
+ Hits        16146    16149       +3     
+ Misses       5773     5770       -3     
  Partials     1057     1057              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
pkg/skaffold/docker/parse.go 87.39% <0.00%> (-0.85%) ⬇️
pkg/skaffold/util/tar.go 65.51% <0.00%> (+2.29%) ⬆️
pkg/skaffold/log/stream/stream.go 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6463b24...c899332. Read the comment docs.

@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Aug 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 19, 2021
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Aug 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Aug 22, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@gsquared94 gsquared94 merged commit a99ffc5 into GoogleContainerTools:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants