fix: TestDebug/buildpacks by pinning go version #6463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This temporarily pins the Go version used by the buildpack-built image used for testing in the "skaffold debug" integration test. It does not fix the problem for the users (i.e. anyone using go1.17 with skaffold debug will still hit this) but it helps us pass the tests on main branch. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
|
/cc @briandealwis |
aaron-prindle
approved these changes
Aug 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #6463 +/- ##
==========================================
+ Coverage 70.25% 70.27% +0.01%
==========================================
Files 508 510 +2
Lines 22942 22976 +34
==========================================
+ Hits 16119 16146 +27
- Misses 5766 5773 +7
Partials 1057 1057
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6450
Related: GoogleContainerTools/container-debug-support#77
Description
This temporarily pins the Go version used by the buildpack-built image
used for testing in the "skaffold debug" integration test.
It does not fix the problem for the users (i.e. anyone using go1.17 with
skaffold debug will still hit this) but it helps us pass the tests on main
branch.
Follow-up Work
We need to find a solution to the user app <=> dlv version skew problem in
GoogleContainerTools/container-debug-support#77
and remove this version pinning (as the pinning itself eventually won't work
for being too old by the newer versions of dlv as we update it).