Wrap tester in SkaffoldRunner
to improve SkaffoldLogEvent
labelling
#6469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5368
Description
This PR adds proper labelling of
SkaffoldLogEvent
s that come from Skaffold's testing phase. I've also added aTest
function onto theSkaffoldRunner
rather than embedding a tester. This allows us to useoutput.WithEventContext
in a way that's more consistent with how we use it for build and deploy phases.SkaffoldLogEvent
s starting fromStarting Test...
up to, but not including,Tags used in deployment
should now have proper task information set.Tests were not added for
SkaffoldRunner.Test
as there is no real logic there, it's simply calling the underlying data structures Test function.