Fix skaffold inspect tests flags and help message #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
commented
Aug 23, 2021
| // TestsOptions holds flag values for various `skaffold inspect tests` commands | ||
| type TestsOptions struct { | ||
| // Profiles is the slice of profile names to activate. | ||
| TestsProfiles []string |
There was a problem hiding this comment.
Note: name TestsProfiles was used in TestOptions (vs Profiles) as the name Profiles is used in the BuildEnvsOptions which would make Profiles ambiguous when used as opts.Profiles
gsquared94
approved these changes
Aug 24, 2021
skaffold inspect tests did not display its flag in its help message initially, the changes here fix this. Additionally the profile and modules flags were not wired up/plumbed properly initially. They are now tested and working as expected
aaron-prindle
force-pushed
the
fix-skaffold-inspect-tests-flags-and-help-msg
branch
from
0def276
to
90ba27c
Compare
Codecov Report
@@ Coverage Diff @@
## main #6493 +/- ##
==========================================
- Coverage 70.31% 70.30% -0.01%
==========================================
Files 512 512
Lines 23031 23037 +6
==========================================
+ Hits 16195 16197 +2
- Misses 5778 5782 +4
Partials 1058 1058
Continue to review full report at Codecov.
|
|
Kokoro is failing for unrelated reason, this change is to a new command and it does not impact the GCP tests that kokoro runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skaffold inspect tests did not display its flag in its help message initially, the changes here fix this. Additionally the profile and modules flags were not wired up/plumbed properly initially. They are now tested and working as expected