Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NewDeployer call in helm test #6501

Closed
wants to merge 1 commit into from

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Aug 24, 2021

this was broken by a bad merge between #6468 and #6454

@nkubala nkubala requested a review from a team as a code owner August 24, 2021 17:32
@google-cla google-cla bot added the cla: yes label Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #6501 (2f862ae) into main (a99ffc5) will increase coverage by 0.04%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6501      +/-   ##
==========================================
+ Coverage   70.27%   70.31%   +0.04%     
==========================================
  Files         510      511       +1     
  Lines       22988    23026      +38     
==========================================
+ Hits        16154    16190      +36     
- Misses       5776     5778       +2     
  Partials     1058     1058              
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/hooks/types.go 75.00% <75.00%> (ø)
pkg/skaffold/deploy/helm/deploy.go 77.91% <100.00%> (+1.09%) ⬆️
pkg/skaffold/deploy/kubectl/kubectl.go 64.07% <100.00%> (ø)
pkg/skaffold/deploy/kustomize/kustomize.go 74.51% <100.00%> (+1.98%) ⬆️
pkg/skaffold/hooks/deploy.go 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65dfd46...2f862ae. Read the comment docs.

@nkubala
Copy link
Contributor Author

nkubala commented Aug 24, 2021

@gsquared94 beat me to it in #6499

@nkubala nkubala closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant