Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6508 - Add skaffold apply to CLI docs header #6509

Merged
merged 2 commits into from Aug 26, 2021
Merged

Fix #6508 - Add skaffold apply to CLI docs header #6509

merged 2 commits into from Aug 26, 2021

Conversation

verbanicm
Copy link
Contributor

Fixes: #6508

Description
Added skaffold apply to CLI docs and ran generate-man.sh

User facing changes (remove if N/A)
CLI Docs will now show skaffold apply in header

@verbanicm verbanicm requested a review from a team as a code owner August 25, 2021 03:16
@google-cla google-cla bot added the cla: yes label Aug 25, 2021
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 I'm rerunning the failed travis jobs

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #6509 (3ebf487) into main (a99ffc5) will increase coverage by 0.14%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6509      +/-   ##
==========================================
+ Coverage   70.27%   70.41%   +0.14%     
==========================================
  Files         510      515       +5     
  Lines       22988    23127     +139     
==========================================
+ Hits        16154    16286     +132     
- Misses       5776     5783       +7     
  Partials     1058     1058              
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
pkg/skaffold/hooks/types.go 75.00% <75.00%> (ø)
pkg/skaffold/deploy/helm/deploy.go 77.91% <100.00%> (+1.09%) ⬆️
pkg/skaffold/deploy/kubectl/kubectl.go 64.07% <100.00%> (ø)
pkg/skaffold/deploy/kustomize/kustomize.go 74.51% <100.00%> (+1.98%) ⬆️
pkg/skaffold/hooks/deploy.go 85.71% <100.00%> (ø)
pkg/skaffold/log/stream/stream.go 71.42% <0.00%> (-14.29%) ⬇️
pkg/skaffold/debug/apply_transforms.go 23.07% <0.00%> (-12.83%) ⬇️
cmd/skaffold/app/cmd/inspect_tests.go 63.63% <0.00%> (-3.04%) ⬇️
pkg/skaffold/test/test_factory.go 76.19% <0.00%> (-1.09%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9327776...3ebf487. Read the comment docs.

@MarlonGamez MarlonGamez merged commit 4913d6a into GoogleContainerTools:main Aug 26, 2021
@verbanicm verbanicm deleted the fix-cli-docs branch August 27, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold apply is missing from CLI overview on docs page
3 participants