New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to wait for connection to /v2/events
on gRPC/HTTP server
#6545
Add option to wait for connection to /v2/events
on gRPC/HTTP server
#6545
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6545 +/- ##
==========================================
+ Coverage 70.44% 70.52% +0.08%
==========================================
Files 515 515
Lines 23144 23152 +8
==========================================
+ Hits 16303 16328 +25
+ Misses 5785 5770 -15
+ Partials 1056 1054 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems this flag could be defined on more commands and it looks like a commented out line was left (see comments)
Description
This PR adds the option for the user to have skaffold pause execution on initialization of the gRPC/HTTP server. Execution will continue when a request to
/v2/events
is made. This will help ensure that users of the server can connect before Skaffold execution ends early in some cases.This PR also moves the call to
event.SendErrorMessageOnce
to the server shutdown callback function, which ensures that the error message gets sent out before the server is shut down.