Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ResourceStatusCheckEvent[Updated/Completed] where appropriate #6550

Merged

Conversation

MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Aug 31, 2021

Related: https://github.com/GoogleCloudPlatform/cloud-code-vscode-internal/issues/5277

Description
This PR changes some of the events that are being emitted by status check phase. We were sending out event completed when we shouldn't be in #6534 which was causing issues.

Also removes some duplicate pod events and messages

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #6550 (3edcbca) into main (290280e) will increase coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6550      +/-   ##
==========================================
+ Coverage   70.48%   70.53%   +0.04%     
==========================================
  Files         515      515              
  Lines       23150    23150              
==========================================
+ Hits        16317    16328      +11     
+ Misses       5776     5768       -8     
+ Partials     1057     1054       -3     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 70.68% <0.00%> (-0.38%) ⬇️
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/server/server.go 46.87% <0.00%> (-0.75%) ⬇️
.../skaffold/kubernetes/status/resource/deployment.go 85.09% <50.00%> (-0.71%) ⬇️
pkg/skaffold/event/v2/event.go 84.22% <66.66%> (-0.37%) ⬇️
pkg/skaffold/build/buildpacks/lifecycle.go 83.59% <100.00%> (ø)
pkg/skaffold/kubernetes/status/status_check.go 52.65% <100.00%> (+0.50%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cee85...3edcbca. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 1, 2021
@MarlonGamez MarlonGamez merged commit a6931b7 into GoogleContainerTools:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants