Implement packaging for helm deployment #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypnoglow
requested review from
dgageot,
dlorenc,
r2d4 and
viglesiasce
as code owners
This commit adds a possibility to package a helm chart before deployment using `helm package` command. This can be useful to set a specific version for a chart. --- One of the workflows that skaffold assumes is to deploy a Helm chart that resides within some directory in the project folder. `Chart.yaml` file in that folder is basically static file, and `--version` flag in `helm install ./path/to/chart --version` command actually does nothing, so does "version:" field in helm section of **skaffold.yaml**. To set a chart version dynamically, we have to use `helm package` command setting `--version` (and optionally `--app-version`) flags accordingly. This commit adds a new section `packaged:` to helm section **skaffold.yaml** that can be used to configure dynamic chart versions.
hypnoglow
force-pushed
the
package-helm-charts-before-deploy
branch
from
7f1c558
to
a0c641b
Compare
r2d4
approved these changes
Jun 15, 2018
hypnoglow
added a commit
to hypnoglow/skaffold
that referenced
this pull request
Jun 18, 2018
hypnoglow
added a commit
to hypnoglow/skaffold
that referenced
this pull request
Jun 19, 2018
hypnoglow
added a commit
to hypnoglow/skaffold
that referenced
this pull request
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note for reviewers: this is a proposal. If you give the green light to it, I will add required tests and documentation.
This commit adds a possibility to package a helm chart before deployment
using
helm packagecommand. This can be useful to set a specific versionfor a chart.
One of the workflows that skaffold assumes is to deploy a Helm chart that
resides within some directory in the project folder.
Chart.yamlfile inthat folder is basically static file, and
--versionflag inhelm install ./path/to/chart --versioncommand actually does nothing,so does "version:" field in helm section of skaffold.yaml.
To set a chart version dynamically, we have to use
helm packagecommandsetting
--version(and optionally--app-version) flags accordingly.This commit adds a new section
packaged:to helm section skaffold.yamlthat can be used to configure dynamic chart versions.