feat: ignore vim *.swp files in hot-reload example #6895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not obvious that `skaffold dev` will rebuild the image even when a file that is not mapped in `skaffold.yaml`'s manual sync config is added or changed. `skaffold dev` instead respects `.dockerignore` as I discovered [in this issue](GoogleContainerTools#3124). Add `**/*.swp` to both node and python directories in the hot-reload example so that this example is more likely to work out-of-the-box for new users. Signed-off-by: David Xia <dxia@spotify.com>
Codecov Report
@@ Coverage Diff @@
## main #6895 +/- ##
==========================================
- Coverage 70.48% 69.13% -1.35%
==========================================
Files 515 547 +32
Lines 23150 25081 +1931
==========================================
+ Hits 16317 17340 +1023
- Misses 5776 6576 +800
- Partials 1057 1165 +108
Continue to review full report at Codecov.
|
|
looks like kokoro is stuck preventing the auto-merge? |
|
hey @davidxia , sorry for the delay on this! I've triggered the kokoro build. I'll merge this when done assuming it goes green |
|
@MarlonGamez thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not obvious that
skaffold devwill rebuild the imageeven when a file that is not mapped in
skaffold.yaml'smanual sync config is added or changed.
skaffold devinsteadrespects
.dockerignoreas I discoveredin this issue.
Add
**/*.swpto both node and python directories in the hot-reloadexample so that this example is more likely to work out-of-the-box
for new users.