Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add end line and col support to lint #6926

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Dec 1, 2021

Changes lint results from only having Line and Column fields to having StartLine, EndLine, StartColumn, EndColumn. This way the flagged text can be more accurate when using an IDE

@aaron-prindle aaron-prindle requested a review from a team as a code owner December 1, 2021 23:37
@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@aaron-prindle aaron-prindle requested review from nkubala and removed request for tejal29 December 1, 2021 23:38
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #6926 (2a1bf14) into main (290280e) will decrease coverage by 1.66%.
The diff coverage is 56.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6926      +/-   ##
==========================================
- Coverage   70.48%   68.81%   -1.67%     
==========================================
  Files         515      551      +36     
  Lines       23150    25296    +2146     
==========================================
+ Hits        16317    17408    +1091     
- Misses       5776     6714     +938     
- Partials     1057     1174     +117     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0579c...2a1bf14. Read the comment docs.

@aaron-prindle aaron-prindle requested review from MarlonGamez and removed request for nkubala December 8, 2021 19:03
@tejal29 tejal29 merged commit 8b355c7 into GoogleContainerTools:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants