Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker build for artifact with cliFlags should use docker CLI #6930

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

briandealwis
Copy link
Member

Fixes: #6929

Description
A Docker build for an artifact that sets cliFlags should always do a CLI build.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #6930 (d146a01) into main (290280e) will decrease coverage by 1.35%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6930      +/-   ##
==========================================
- Coverage   70.48%   69.12%   -1.36%     
==========================================
  Files         515      547      +32     
  Lines       23150    25066    +1916     
==========================================
+ Hits        16317    17327    +1010     
- Misses       5776     6576     +800     
- Partials     1057     1163     +106     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/flags.go 91.00% <0.00%> (+0.18%) ⬆️
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feafa43...d146a01. Read the comment docs.

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briandealwis briandealwis merged commit 7ac9110 into GoogleContainerTools:main Dec 3, 2021
@briandealwis briandealwis deleted the i6929 branch December 3, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker builds with cliFlags should be build with docker CLI
2 participants