Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't send error in skaffoldLogEvent if error is nil #6945

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

MarlonGamez
Copy link
Contributor

Fixes: #6747

Description
This PR updated the function used to send our error message through the event stream. It now should not be sending a final error message if the error is nil

@MarlonGamez MarlonGamez requested a review from a team as a code owner December 7, 2021 23:59
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #6945 (0ddf78b) into main (290280e) will decrease coverage by 1.66%.
The diff coverage is 56.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6945      +/-   ##
==========================================
- Coverage   70.48%   68.81%   -1.67%     
==========================================
  Files         515      551      +36     
  Lines       23150    25267    +2117     
==========================================
+ Hits        16317    17388    +1071     
- Misses       5776     6710     +934     
- Partials     1057     1169     +112     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0579c...0ddf78b. Read the comment docs.

@tejal29 tejal29 merged commit 0d05992 into GoogleContainerTools:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%!s(<nil>)\n printed at termination of dev session
2 participants