fix: bugs for skaffold.yaml files read in via stdin #6970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix modifies the behavior for 2 pieces of how skaffold.yaml's read in via stdin work:
SourceFile
field for a SkaffoldConfigEntry is-
for files read in viastdin
instead of /abs/path/skaffold.yaml/- which is what the value is currently.util.ReadConfiguration
is idempotent for skaffold.yaml files read in viastdin
by storing the []byte fromos.Stdin
that are read in. Currently once theReader
that is os.Stdin is read, subsequent calls toutil.ReadConfiguration
are empty forstdin
skaffold.yaml filesThese changes are required for supporting
stdin
for skaffold.yaml's with the line # support that #6955 provides