Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to buildpacks/pack v0.23.0 #6979

Merged
merged 5 commits into from
Jan 26, 2022

Conversation

briandealwis
Copy link
Member

Fixes: #6948

Copy link

@SSGoku369 SSGoku369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@SSGoku369

This comment was marked as spam.

@briandealwis
Copy link
Member Author

TIL: ioutil.ReadFile(filepath.Clean("")) produces a different error from ioutil.ReadFile("") https://go.dev/play/p/qTSZOT-4Vk9

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #6979 (7712bfa) into main (290280e) will decrease coverage by 1.70%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6979      +/-   ##
==========================================
- Coverage   70.48%   68.78%   -1.71%     
==========================================
  Files         515      554      +39     
  Lines       23150    25860    +2710     
==========================================
+ Hits        16317    17787    +1470     
- Misses       5776     6868    +1092     
- Partials     1057     1205     +148     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887886b...7712bfa. Read the comment docs.

@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Jan 20, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 20, 2022
@briandealwis
Copy link
Member Author

I wish we had a /rebase action.

@MarlonGamez
Copy link
Contributor

Looks like it's still pulling the latest tagged imaged from gcr, think we'll have to rebuild and push ourselves? I'm not sure if there is a job somewhere that rebuilds that image or if it has always been manually done

@briandealwis
Copy link
Member Author

briandealwis commented Jan 20, 2022

@briandealwis
Copy link
Member Author

Filed #7038 to cause the build_deps image to be updated.

@briandealwis briandealwis marked this pull request as ready for review January 20, 2022 22:31
@briandealwis briandealwis requested a review from a team as a code owner January 20, 2022 22:31
@MarlonGamez MarlonGamez added the kokoro:force-run forces a kokoro re-run on a PR label Jan 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildpack default launch type is no longer correct
5 participants