fix(ko): Debug port forwarding for ko:// images
#7009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that images with the `ko://` prefix have the `dlv` debug port forwarded by default when running `skaffold debug`. The image build process sanitizes the image name by removing the `ko://` prefix and lowercasing the Go import path. This means that the built image name doesn't match the placeholder values in the Kubernetes manifest files. This change sanitizes the image placeholder values from the Kubernetes resource files when matching with the built image names, which in turn means that Skaffold sets up port forwarding. Fixes: GoogleContainerTools#6995
Codecov Report
@@ Coverage Diff @@
## main #7009 +/- ##
==========================================
- Coverage 70.48% 68.76% -1.72%
==========================================
Files 515 554 +39
Lines 23150 25694 +2544
==========================================
+ Hits 16317 17669 +1352
- Misses 5776 6824 +1048
- Partials 1057 1201 +144
Continue to review full report at Codecov.
|
halvards
added
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that images with the
ko://prefix have thedlvdebug port, and other default ports, forwarded by default when runningskaffold debug.The image build process sanitizes the image name by removing the
ko://prefix and lowercasing the Go import path. This means that the built image name doesn't match the placeholder values in the Kubernetes manifest files.This change sanitizes the image placeholder values from the Kubernetes resource files when matching with the built image names, which in turn means that Skaffold sets up port forwarding.
Fixes: #6995
Tracking: #6041