Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): validate generated/provided tag #7042

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

hown3d
Copy link
Contributor

@hown3d hown3d commented Jan 22, 2022

Fixes: #5979

Description

Add a validation for generated/provided tag. Will error if generated image name can't be parsed by docker.

@hown3d hown3d requested a review from a team as a code owner January 22, 2022 14:42
@hown3d hown3d requested a review from tejal29 January 22, 2022 14:42
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Jan 26, 2022
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #7042 (5d51913) into main (290280e) will decrease coverage by 1.68%.
The diff coverage is 56.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7042      +/-   ##
==========================================
- Coverage   70.48%   68.79%   -1.69%     
==========================================
  Files         515      554      +39     
  Lines       23150    25875    +2725     
==========================================
+ Hits        16317    17801    +1484     
- Misses       5776     6867    +1091     
- Partials     1057     1207     +150     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 52.00% <ø> (-1.85%) ⬇️
cmd/skaffold/app/cmd/dev.go 84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 36.66% <0.00%> (-4.72%) ⬇️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go 68.85% <40.00%> (-7.62%) ⬇️
cmd/skaffold/app/cmd/lint.go 42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.88% <50.00%> (+0.24%) ⬆️
cmd/skaffold/app/skaffold.go 76.19% <70.00%> (-8.43%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb56aa...5d51913. Read the comment docs.

@MarlonGamez
Copy link
Contributor

Thanks for this contribution @hown3d !

@MarlonGamez MarlonGamez merged commit b5b3893 into GoogleContainerTools:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold should guard against invalid tags
4 participants