fix: dont update last-prompted if check-update is false

[tomasmota]

Fixes: #7051

Description
When check-update is set to false, the config property last-prompted was being updated even though the user is not prompted. This has been fixed.

Notes
Also removed a test regarding the survey prompt that was being ran as part of the update message unit tests (coverage not affected)

[briandealwis]

I think this looks reasonable — wdyt @tejal29?

[tejal29]

I think this looks reasonable — wdyt @tejal29?

Agree. We did discuss on the issue opened for the same.

[codecov]

Codecov Report

Merging #7067 (a419b8e) into main (290280e) will decrease coverage by 1.71%.
The diff coverage is 56.96%.

@@            Coverage Diff             @@
##             main    #7067      +/-   ##
==========================================
- Coverage   70.48%   68.77%   -1.72%     
==========================================
  Files         515      554      +39     
  Lines       23150    25880    +2730     
==========================================
+ Hits        16317    17798    +1481     
- Misses       5776     6873    +1097     
- Partials     1057     1209     +152     

Impacted Files	Coverage Δ
cmd/skaffold/app/cmd/deploy.go	52.00% <ø> (-1.85%)	⬇️
cmd/skaffold/app/cmd/dev.go	84.61% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go	36.66% <0.00%> (-4.72%)	⬇️
cmd/skaffold/skaffold.go	0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go	62.50% <14.28%> (-1.14%)	⬇️
cmd/skaffold/app/cmd/lsp.go	28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/fix.go	68.85% <40.00%> (-7.62%)	⬇️
cmd/skaffold/app/cmd/lint.go	42.85% <42.85%> (ø)
cmd/skaffold/app/cmd/find_configs.go	48.88% <50.00%> (+0.24%)	⬆️
cmd/skaffold/app/skaffold.go	76.19% <70.00%> (-8.43%)	⬇️
... and 186 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf98065...a419b8e. Read the comment docs.

[tomasmota]

The windows unit test falure looks like a flake, should we just re-run it @tejal29?

[tomasmota]

Just ran 'go test -short -timeout 60s ./pkg/skaffold/... ./cmd/... ./hack/... ./pkg/webhook/...' on a windows machine and all tests passed fine :/